bb00 / zer0dump

Abuse CVE-2020-1472 (Zerologon) to take over a domain and then repair the local stored machine account password.
176 stars 44 forks source link

Deleted dependency detected #7

Open ashishbijlani opened 10 months ago

ashishbijlani commented 10 months ago

I'm a Cyber Security researcher and developer of PackjGuard [1] to address open-source software supply chain attacks.

Issue

During my research, I found that this repo is vulnerable to attack due to missing deleted dependency from the public PyPI registry.

Details

Specifically, file https://github.com/bb00/zer0dump/blob/06fa182b4a984518dfebe5dc07d16373d23b795c/requirements.txt lists crackmapexec as one of the dependencies. However, it has been deleted from public PyPI. As such, an external bad actor can claim that name and register a malicious package, which will be then installed with pip install command, resulting in arbitrary remote code execution.

Impact

Not only your apps/services using https://github.com/bb00/zer0dump repo code are vulnerable to this attack, but the users of your open-source Github repo could also fall victim.

You could read more about such attacks here: https://medium.com/@alex.birsan/dependency-confusion-4a5d60fec610

Remediation

Please manually register a placeholder crackmapexec package on PyPI immediately or remove crackmapexec dependency from https://github.com/bb00/zer0dump/blob/06fa182b4a984518dfebe5dc07d16373d23b795c/requirements.txt to fix this vulnerability.

To automatically fix such issues in future, please install PackjGuard Github app [1].

Thanks!

  1. PackjGuard is a Github app that monitors your repos 24x7, detects vulnerable/malicious/risky open-source dependencies, and creates pull requests for auto remediation: https://github.com/marketplace/packjguard