search

bb30 / adbackup

backup tool for android written in rust
MIT License
3 stars 2 forks source link

split into mod and cli tool #11

Closed DonatJR closed 6 years ago

DonatJR commented 6 years ago

PR for #9 I just did the logging / printing change for now, please have a look at it and tell me if you are okay with it or if you maybe have a better idea...

SailReal commented 6 years ago

LGTM but if I understand it right, 

let result = sub_fn();
    if let Some(error) = result.err() {
        error!("adbackup finished with error: {}", error.to_string());
}

would print in the error-case nothing to the console? We have to use println! at this point, right? adbackup-cli.rs#L34

DonatJR commented 6 years ago

yep, you are right on that one. I only changed to println for code I actually touched :/ will fix

DonatJR commented 6 years ago

with these new changes the cli tools writes only to stdout and the module writes only to the log-file, please have a look @SailReal

SailReal commented 6 years ago

Looks really amazing, thx for the improvement!