search

bbaia / protractor-net

The .NET port of Protractor, an E2E test framework for Angular apps
MIT License
115 stars 72 forks source link

Implements version in .net-core #72

Closed alabras closed 4 years ago

alabras commented 6 years ago

The version in .net-core is implemented. It would be necessary to include it in the build, to be added to the nuget package.

All test is passed, except PageObjectsTests, because OpenQA.Selenium.Support.PageObjects.PageFactory is deprecated https://github.com/SeleniumHQ/selenium/blob/f45fe9bb320f7e8a0dd44eeae76377b7bb895104/dotnet/src/support/PageObjects/PageFactory.cs#L29

baodrate commented 6 years ago

Sorry if this is a dumb question. Why is this a NET Core app instead of a NET Standard library?

alabras commented 6 years ago

Mmmm It could be, when I implemented it I did not think about that possibility.

baodrate commented 6 years ago

I think it would be a good idea. It would let users of the library target .net standard. For example, my library is targeting standard and I can't include protractor without it (or I'd have to target both Framework and Core, which makes deployment a little more annoying). I haven't used protractor yet but since it wraps selenium I don't think it should be too much issue to target Standard instead.

Thank you for the PR, btw. I was just starting to explore protractor and was wondering why it was only targeting .net framework

baodrate commented 6 years ago

@alabras I've implemented a .NET Standard solution (and .NET Core for the test project). Please tell me what you think.

alabras commented 6 years ago

It looks good, but the tests are ok?

Send your PR. Hopefully @bbaia, see them and merge with Master.

baodrate commented 6 years ago

Sorry, I didn't check all the tests. There's still some fixes (I forgot to specify the ChromeDriver directory, and assembly.GetManifestResourceStream doesn't seem to be working). I'll make those fixes tomorrow.

I have some reservations about making a PR because .NET Core support will require new versions of some packages, especially Selenium which doesn't support .NET Core until version 3.6.0. This would mean different package requirements for the NET Framework and NET Core.

I'll make the pull request but I'd prefer to have @bbaia's input on how to proceed with moving the package forward, i.e. should the old .NET Framework builds be dropped in favor of supporting .NET Standard across the board, which moves the .NET Framework version prerequisite to 4.6, or maintain the different builds and version requirements.

dessap commented 4 years ago

found one released version here https://github.com/qubidt/protractor-net-standard but with the issue #78 in the codebase.

bbaia commented 4 years ago

.NET Core is supported in v0.13.0 (with .NET Standard 2.0 support)