search

bbalasub1 / glmnet_python

GNU General Public License v3.0
200 stars 95 forks source link

Python 2.7 compatibility #21

Closed staubda closed 6 years ago

staubda commented 6 years ago

Hey there, curious if you guys are interested in adding compatibility for Python 2 to this project. I've created a fork making the (few) necessary changes.

I've also done a bit of PEP8ing because I couldn't help myself. Happy to submit a PR if you're interested. You may need to run pip install future --upgrade to get it to work.

bbalasub1 commented 6 years ago

That would be very helpful. I will take a look. Thanks.

On Tuesday, January 9, 2018, David Staub notifications@github.com wrote:

Hey there, curious if you guys are interested in adding compatibility for Python 2 to this project. I've created a fork https://github.com/staubda/glmnet_python making the (few) necessary changes.

I've also done a bit of PEP8ing because I couldn't help myself. Happy to submit a PR if you're interested. You may need to run pip install future --upgrade to get it to work.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bbalasub1/glmnet_python/issues/21, or mute the thread https://github.com/notifications/unsubscribe-auth/AKpDE0rIWDDnvYczQh2lipE-mGCRCc4Wks5tI_LVgaJpZM4RYlM8 .

bbalasub1 commented 6 years ago

Since all of the testing was performed for 3.6, probably best if we keep it 3.6 compatible.