Update scipy to numpy functions

johnlees commented 4 years ago

Please consider this pull request to your repository. The fork is the version currently installable via conda-forge. I have made the following changes, mostly by running pylint and fixing errors:

Change scipy array functions to numpy. The scipy functions are deprecated and cause warnings, and in future will cause errors. scipy is still used for interpolation and sparse matrices.
Fix a variable name in cvlognet.py:l170
Fix taking the negative of a list rather than array in glmnetPredict.py:l184
Remove some errant semicolons that found their way over from the fortran (no function, but cleans code a little)

I have also changed the setup.py so that the fortran extension is built automatically (which requires gfortran to be installed). I am not sure whether you want this change, I guess updating the installation instructions here would be needed. There are a couple of changes to the author lines in setup.py brought in through merging you may want to revert too.

Best wishes, John Lees

johnlees commented 4 years ago

Fix taking the negative of a list rather than array in glmnetPredict.py:l184

This was incorrect, and has now been fixed by reverting to the original code

johnlees commented 4 years ago

This was one I modified to get it to work with conda build. If you'd prefer, I can modify so that the one from the master branch is kept instead of these changes?

stevemandala commented 1 year ago

This PR would likely resolve https://github.com/bbalasub1/glmnet_python/issues/64

bbalasub1 / glmnet_python

Update scipy to numpy functions #47