bbalet / jorani

Leave and Overtime Management System
http://jorani.org/
GNU Affero General Public License v3.0
389 stars 276 forks source link

Question: composer needed in release DOCKERFILE (zip)? #393

Closed JohannesFleischer closed 1 year ago

JohannesFleischer commented 1 year ago

In my understanding, the composer in the DOCKERFILE generates the vendor folder, which is excluded from git with the .gitignore. The release zip on the other hand already includes this folder.

So my question is if

FROM composer as composer
COPY composer.json composer.lock ./
RUN composer install --ignore-platform-reqs --no-dev

and

COPY --from=composer /app/vendor /var/www/html/vendor

can be removed from the release Dockerfile without breaking anything.

bbalet commented 1 year ago

Hi,

Yes it can be removed if you want to use it from the release package. The release package is intended for people not using Docker (e.g. people using Jorani from a shared hosting