search

bbangert / lettuce_webdriver

Selenium webdriver for lettuce
MIT License
81 stars 32 forks source link

Infoxchange steps upstreaming #30

Closed danni closed 11 years ago

danni commented 11 years ago

This is a pretty epic branch.

It started out as pulling out all of the private steps I've used in a project here at Infoxchange. I then did some pep8 cleanups and refactored the test suite, before writing some tests, and then fixing up some deficiencies in the steps. I then did a bit more refactoring to hopefully make a few XPath lookups faster on big DOMs.

Steps are all separate in case you only want to cherry-pick some of them; although I think they're all generally useful.

danni commented 11 years ago

Optionally I can also upstream some hooks for automatically setting up and tearing down the browser. Including environment variables WEBDRIVER and WEBDRIVER_HOST to configure what to run. Also handles inter-scenario handling of the beforeunload event (to stop changing scenario wedging your browser).

npilon commented 11 years ago

@danni I don't see any beforeunload-related changes here...?

danni commented 11 years ago

That's because those changes are not included. Are you interested in them?

npilon commented 11 years ago

I'd be interested in seeing them, yeah. Our QA guy has reported some odd inter-test behavior, and if you've already fixed it, that saves me a ton of time. In the meantime, I don't see anything especially odd here.

danni commented 11 years ago

Yeah, at the moment one failing test can cause others to fail.