Add HTML5 fields to input_has_value

[npilon]

At this point is running all of these xpath expressions in series really the best way for us to do this?

[danni]

It's not because it's n round trips to Se. I looked at refactoring it but it's a larger piece of work.

On Friday, 21 March 2014, Nicholas Pilon notifications@github.com wrote:

At this point is running all of these xpath expressions in series really the best way for us to do this?

— Reply to this email directly or view it on GitHubhttps://github.com/bbangert/lettuce_webdriver/pull/42#issuecomment-38197017 .

[npilon]

I'm pretty concerned about the effects of this on anyone testing using, eg, BrowserStack, since each of these calls results in three round trips. But I also can't see an easy way to improve the xpath to reduce the number of trips.

Then again, my xpath is also very rusty.

[danni]

Yeah it's certainly a problem and one I've run into. We can put options into XPath it's just a pain the way the code is written atm.

Need to refactor it to have a query builder.

On Thursday, 27 March 2014, Nicholas Pilon notifications@github.com wrote:

I'm pretty concerned about the effects of this on anyone testing using, eg, BrowserStack, since each of these calls results in three round trips. But I also can't see an easy way to improve the xpath to reduce the number of trips.

Then again, my xpath is also very rusty.

— Reply to this email directly or view it on GitHubhttps://github.com/bbangert/lettuce_webdriver/pull/42#issuecomment-38736531 .

[koterpillar]

@npilon can you please take another look?

[koterpillar]

@npilon Now there's only XPathSelector.

[npilon]

Overall I think this is much cleaner. @danni are you happy with the changes?

[danni]

++