search

bbangert / retools

Redis Tools
MIT License
138 stars 41 forks source link

This fixes an issue with StrictRedis and zadd. #25

Closed heynemann closed 10 years ago

heynemann commented 10 years ago

The redis-py StrictRedis connection class adheres to the actual redis API definition. Usually this is not an issue as redis-py Redis class methods have the same list of arguments.

The issue arises when using ZADD, since in redis it expects the ordered set name and the items to add with score and key in this order.

StrictRedis uses the correct order of arguments, whereas Redis inverts key and score. This gives users an exception if they use Retools Limiter as it is implemented today with a StrictRedis connection.

heynemann commented 10 years ago

Sorry for this issue. I didn't test with StrictRedis before. Whenever you can release this it would be great!

heynemann commented 10 years ago

Hi @bbangert,

Anything I can do to speed up adopting this pull request? Sorry for asking for this, but we are really in need of getting a new release done (0.4.1?) to use in our project as this issue renders retools useless for us (we use StrictRedis).

If I can do anything to help, let me know.

Thanks!

heynemann commented 10 years ago

Thank you so much!

bbangert commented 10 years ago

I'll try and get a release out in the next day or two.

bbangert commented 10 years ago

Ok, released 0.4.1 with this. Cheers!

heynemann commented 10 years ago

Thank you very much! Hope to contribute even more in the future!