Use namespaced session keys to avoid clashes, and pop after use

bbangert / velruse

Simplifying third-party authentication for web applications.

http://packages.python.org/velruse/index.html

MIT License

252 stars 86 forks source link

Closed asabil closed 11 years ago

mmerickel commented 11 years ago

I'm not sure of a use-case where anyone should be trying to login to multiple providers simultaneously but at least velruse.token makes sense.

asabil commented 11 years ago

I will amend the commit to remove the provider name from the session keys then.

asabil commented 11 years ago

Pull request updated

invisibleroads commented 11 years ago

I agree with Ali that session variables should be namespaced to prevent conflicts with other plugins. Thanks, Ali.

mmerickel commented 11 years ago

This looks good, sorry for the delay!