search

bbartling / open-fdd

Fault Detection Diagnostics (FDD) for HVAC datasets
MIT License
55 stars 14 forks source link

Revise FD charts in reports #16

Closed bbartling closed 7 months ago

bbartling commented 1 year ago

@christopherDT thanks for finding this...

https://stackoverflow.com/questions/3681872/shading-an-area-between-two-points-in-a-matplotlib-plot

Final solution would just be one combined plot: image

https://gist.github.com/christopherDT/129883b6dda40216aabd8a8b74beb818

christopherDT commented 1 year ago

This is now included in the PR you just approved. Two main things to be fixed on plotting:

  1. color palette should differ between subplots (gives better contrast between subplots)
  2. there's nothing in the legend to indicate that the blue strips are fault locations. Would be good to include that in the legend. I'm not super familiar with the nitty gritty of matplotlib, so not sure how to just add something to the legend.

Bonus: considering changing this to something like seaborn, which has nicer high-level plotting features