bbartling / open-fdd

Fault Detection Diagnostics (FDD) for HVAC datasets
MIT License
59 stars 14 forks source link

totally overhauled ahu reports __init__ file #17

Closed christopherDT closed 1 year ago

christopherDT commented 1 year ago

Makes use of classes and templating to make the docx report, cleaning up and reducing redundant code.

Unfortunately, this now only works with an older version of the repo (still existing on my fork at the reports_refactor branch). Will need to figure out how to integrate this into the new flow of the repo

christopherDT commented 1 year ago

@bbartling let me know what you think about this new version of the reports and how we might integrate it into the new flow. I've been living in my own little forked world and haven't paid any attention to the revamping to other parts of the repo that's been done since...

bbartling commented 1 year ago

Great thank you!! Will get this merged in soon to go along with the newest Streamlit app web interface that isn't quite done yet.

On Wed, May 10, 2023, 11:19 PM Christopher Dudas-Thomas < @.***> wrote:

@bbartling https://github.com/bbartling let me know what you think about this new version of the reports and how we might integrate it into the new flow. I've been living in my own little forked world and haven't paid any attention to the revamping to other parts of the repo that's been done since...

— Reply to this email directly, view it on GitHub https://github.com/bbartling/open-fdd/pull/17#issuecomment-1543308908, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHC4BHPER2U7AARTKUZ52TLXFRSEZANCNFSM6AAAAAAX5RKM34 . You are receiving this because you were mentioned.Message ID: @.***>