helm-projectile-grep not respecting projectile-globally-ignored-file-suffixes

clayliddell commented 4 years ago

Expected behavior

When searching for a file using helm-projectile-grep, files with a suffix matching projectile-globally-ignored-file-suffixes should not appear in results.

Actual behavior

Files containing the ignored suffixes appear in the results.

Steps to reproduce the problem

Create a file with a unique suffix inside of a projectile project.
Inside the file place "test".
Add your unique file suffix to 'projectile-globally-ignored-file-suffixes'.
use help-projectile-grep to search for files containing "test" and confirm that the file created in step 1 appears.

Environment & version information

helm-projectile version: 20200615.527
helm version (in helm-pkg.el): 20200623.1058
projectile version (M-x projectile-version): 2020616.1659
Emacs version (M-x emacs-version): 26.3
OS: Ubuntu 18.04

obar commented 4 years ago

Have you tried ripgrep via helm-projectile-rg? Take a look at #61 for the background, you'd need to install the ripgrep (rg) binary on your system as well as the elisp package helm-rg. The plus side is, it's very fast.

clayliddell commented 4 years ago

@obar Thanks for the suggestion! I'll have to check that out. I'll report my success here once I've given it a go.

clayliddell commented 4 years ago

So, I ended up using ripgrep; however, I was having a bit much trouble getting helm-rg to work properly, and the project appears to be abandoned, so instead I'm just using helm-ag and helm-project-do-ag in conjunction with ripgrep under the hood. Sadly I was unable to get helm-projectile-ag to work properly due to #58; however helm-project-do-ag seems to satisfy my needs at the moment.

I would still consider this to be a bug with helm-projectile so I'm leaving this ticket open for record keeping sake. Thanks again for the suggestion @obar!

bbatsov / helm-projectile