Avoid overriding user configurations in helm-projectile-toggle

bbatsov commented 8 years ago

This toggle command should be a minor mode, but your changes are a step in the right direction for sure.

jdreaver commented 8 years ago

Hey, this commit seems to have broken the key bindings for me. If I use the key sequence for what should be a helm-projectile command, I just get the normal projectile command. If I run C-h f helm-projectile-ag, for example, it looks like the keys are bound as this commit intends them to be:

helm-projectile-ag is an interactive autoloaded compiled Lisp function in
`helm-projectile.el'.

It is bound to C-c p <remap> <projectile-ag>.

(helm-projectile-ag &optional OPTIONS)

Helm version of projectile-ag.

However, running C-c p s s calls projectile-ag and not helm-projectile ag. Do you have any idea why the remap isn't working? I am on Emacs 24.5.1.

EDIT: I should add my projectile config, which is just the bare-bones:

  (use-package projectile
    :ensure t
    :config
    (projectile-global-mode))
  (use-package helm-projectile
    :ensure t
    :config
    (helm-projectile-on))
  (use-package ag
    :ensure t)
  (use-package helm-ag
    :ensure t)

I've tried fiddling with the order of these to no avail.

Malabarba commented 8 years ago

Odd. Looks like remap doesn't work in nested maps. See #27

bbatsov / helm-projectile

Avoid overriding user configurations in helm-projectile-toggle #26