search

bbatsov / helm-projectile

Helm UI for Projectile
327 stars 71 forks source link

Should helm-projectile-find-file swallow errors? #92

Closed colonelpanic8 closed 6 years ago

colonelpanic8 commented 6 years ago

helm-projectile-find-file swallows errors, but I'm struggling to figure out why it should do this.

https://github.com/bbatsov/helm-projectile/blob/0e9ba276b3fbc420b8cbdc1b99262ccd5c750db7/helm-projectile.el#L502

What advantage does this confer? In my case it covered up an error that had to do with how I had configured emacs and resulted in an empty file list when attempting to open a file.

xiongtx commented 6 years ago

I'd guess it's because projectile-project-root signals an error when you're not inside a project and projectile-require-project-root is non-nil.

You can see similar uses of condition-case (which really should be ignore-errors, since that's a built-in macro) in Projectile itself.

I'm not sure that showing the user an empty buffer is better than informing them they're not in a project though--what do you think, @IvanMalison & @bbatsov?