search

bbatsov / projectile

Project Interaction Library for Emacs
https://docs.projectile.mx
GNU General Public License v3.0
4k stars 583 forks source link

[Proposal] Should projectile-compile-project support comint-mode? #1669

Closed TxGVNN closed 3 years ago

TxGVNN commented 3 years ago

Hi @bbatsov,

Today, I ran a command need interactively then I see projectile-compile-project doesn't support comint-mode as compile command is doing.

Should we support it?

Expected behavior

C-u M-x projectile-compile-project run (compile cmd t) as C-u M-x compile

Actual behavior

C-u M-x projectile-compile-project has the meaning same with (setq compilation-read-command t).

Proposal

We had compilation-read-command to decide to read the command or not. So I propose use (C-u) PREFIX to decide to run comint-mode in compilation mode.

If you see that makes sense and agree on this change. I can take time to work on it

TxGVNN commented 3 years ago

I switched to use project-compile instead, thanks.

bbatsov commented 3 years ago

Fair enough.

bbatsov commented 3 years ago

Fixed by https://github.com/bbatsov/projectile/pull/1672