search

bbatsov / solarized-emacs

The Solarized colour theme, ported to Emacs.
775 stars 176 forks source link

get rid of solarized-theme.el from theme path #370

Open thomasf opened 4 years ago

thomasf commented 4 years ago

It is detected as a theme by the custom theme system even if it isn't.

The solution is maybe move the actual themes into their own subdirectory?

thomasf commented 3 years ago

The only reason that that file is there seems to be to have a file with the same name as the melpa package (?).

So if we just remove this file the code below would probable stop working correctly.

(use-package solarized-theme
  :ensure t
  :defer)
bbatsov commented 3 years ago

The only reason that that file is there seems to be to have a file with the same name as the melpa package (?).

I think this can also be replaced with some package manifest file, but I never tried it. See https://www.gnu.org/software/emacs/manual/html_node/elisp/Multi_002dfile-Packages.html

For example, if we distribute version 1.3 of the superfrobnicator as a multi-file package, the tar file would be superfrobnicator-1.3.tar. Its contents would extract into the directory superfrobnicator-1.3, and one of these would be the file superfrobnicator-pkg.el.

Seems like a trivial change.