search

bbatsov / zenburn-emacs

The Zenburn colour theme ported to Emacs
GNU General Public License v3.0
1.01k stars 267 forks source link

inherit faces are not propperly applied #149

Open impaktor opened 10 years ago

impaktor commented 10 years ago

As hinted at in https://github.com/bbatsov/zenburn-emacs/pull/147 it now seems that none of the :inherit font-lock-... are being applied properly.

A quick search shows there are just under 20 inherits of this kind in the theme. One of the first is in eshell, and it's easily reproducible: M-x eshell, then do a "ls" in a folder containing a file "foo~". Its face is LightSalmon and not zenburn-green as the inherit from font-lock-comment-face would have been.

    `(eshell-ls-backup ((t (:inherit font-lock-comment-face))))

Same goes for cited text in a message-mode buffer:

    some text

    > cited text

turns up as LightPink1, rather than 

    `(message-cited-text ((t (:inherit font-lock-comment-face))))
tarsius commented 10 years ago

I have not seen this issue in a while but not that I have updated to Emacs 24.3.50 many faces are broken once more due to this issue. I am not so confident that this issue will fixed for good any time soon.

@bbatsov Should we just give up on :inherit altogether? I can make the change if you want. Are you using 24.3.50 yet?

Ps: We have to differentiate between using :inherit inside zenburn to inherit from some other themed face, and theming faces whose default definition inherit from some other default definition. I think currently both are broken, but would have to create some dummy theme to test properly.