search

bbatsov / zenburn-emacs

The Zenburn colour theme ported to Emacs
GNU General Public License v3.0
977 stars 269 forks source link

Customize company-quickhelp colors #296

Closed arichiardi closed 6 years ago

bbatsov commented 6 years ago

Thanks!

arichiardi commented 6 years ago

I have a question though, what happens when the vars are not defined (actually are defined later in the init file)? I guess no errors are thrown as I don't see any but also the colors are missing..

basil-conto commented 6 years ago

The settings added in this PR are in the wrong place. They are variables, not faces, so they should go under custom-theme-set-variables, not custom-theme-set-faces.

Apart from that, custom themes are free to apply settings to as-of-yet undefined variables/faces. The settings only take effect when the theme is enabled and if/when the variables/faces are defined and used.

arichiardi commented 6 years ago

Oh that is why I was not able to see them, sorry I am a bit of a newbie on these things

basil-conto commented 6 years ago

No harm done (except perhaps some error messages on your end :). Just open a new PR moving the settings to the custom-theme-set-variables call near the end of zenburn-theme.el.

arichiardi commented 6 years ago

Will do