Add option for variable pitch headings

bbatsov / zenburn-emacs

The Zenburn colour theme ported to Emacs

GNU General Public License v3.0

977 stars 269 forks source link

Add option for variable pitch headings #313

Closed georgek closed 5 years ago

georgek commented 5 years ago

Addresses #308

bbatsov commented 5 years ago

I guess this PR should also tackle other known heading faces - e.g. for markdown-mode, adoc-mode, etc.

bbatsov commented 5 years ago

I just remembered we already did something similar for https://github.com/bbatsov/solarized-emacs/blob/master/solarized.el, so I'd rather just adopt the same setup for consistency.

georgek commented 5 years ago

Ah OK, yeah that would be much better. I thought a bit about how to do this last night but not for very long. I'll just port those features of solarized theme to zenburn, then.

As for the autoloads, I thought it might be so the options appear in customize before the module has been loaded. But I don't know and just copied the autoload from the other defcustom. Solarized doesn't seem to have them.

It's almost like we could do with some kind of meta-theme that makes it easy to have these features in any theme...

georgek commented 5 years ago

Done.

Markdown isn't actually given any special treatment in zenburn or solarized it seems, unless I'm missing something. We could easily add the equivalent faces for markdown and any others, I guess.

bbatsov commented 5 years ago

@georgek Can you also do the following:

add :package-version properties to the defcustoms, so users would know when we added them
mention those in the readme
add some screenshots to the readme with/without the variable pitch enabled

Thanks in advance!

georgek commented 5 years ago

Done. I took the screenshots with an emacs -Q and DejaVu Sans fonts.

bbatsov commented 5 years ago

Great work!