Additional attribute tweaks

[lgmills]

Thanks for all your updates to this cookbook! I have a few other comments:

Attributes:

• default version should be updated to 3.4.6, as 3.4.5 has just disappeared from the apache mirrors
• suggest that ZOO_LOG4J_PROP be changed to "INFO,ROLLINGFILE" (i.e. eliminate CONSOLE) so that duplicate INFO and above messages don't appear in the "zookeeper.out" file - those are captured in the "zookeeper.log" file.

In the zookeeper_helper library, I added some additional node attributes to match the server list against; these were helpful in my chef-solo deployments on AWS EC2:

  def does_server_match_node? server
    # We check that the server value is either the node's fqdn, hostname,
    # machinename, or ipaddress, including the EC2 equivalents. We also check
    # if the value is of the form [HOST]:[PORT]:[PORT] which is also
    # valid in the case of defining quorum and leader election ports.
    server == node["fqdn"] || server.start_with?("#{node["fqdn"]}:") ||
    server == node["hostname"] || server.start_with?("#{node["hostname"]}:") ||
    server == node["ipaddress"] || server.start_with?("#{node["ipaddress"]}:") |
|
    server.start_with?("#{node["machinname"]}:") || server.start_with?("#{node["
machinename"]}:") ||
    server == node["ec2"]["public_hostname"] || server.start_with?("#{node["ec2"
]["public_hostname"]}:") ||
    server == node["ec2"]["public_ipv4"] || server.start_with?("#{node["ec2"]["p
ublic_ipv4"]}:")
  end

[bbaugher]

• Switched to using the archive URL so the artifact doesn't go away, https://github.com/bbaugher/apache_zookeeper/commit/662e464c9b9ab99eb717e777059b3df6a8913689
• Removed CONSOLE from ZOO_LOG4J_PROP, https://github.com/bbaugher/apache_zookeeper/commit/36432caea2100c79cb5b1b25307f9ab917cb46cf
• Added logic to include ec2 identities against zookeeper servers attribute, https://github.com/bbaugher/apache_zookeeper/commit/bf5cd6c430a2a5b22285de0abb89ef3e9d3832ba

[bbaugher]

This has been released