search

bbaugher / apache_zookeeper

Chef cookbook for Apache Zookeeper
MIT License
9 stars 22 forks source link

Zookeeper restarts every time #33

Closed Sagarsaurus closed 9 years ago

Sagarsaurus commented 9 years ago

I looked through the code and I see where zookeeper restarts every time. Could you possibly make this an attribute that can be overridden so that it doesn't restart every single time it runs? In the environment where I'm working a chef run happens ever 30 mins. If zookeeper restarts every time it could cause some serious performance issues. Is there a way to abstract that portion out so that it doesn't restart unless some attribute is specifically set to true?

bbaugher commented 9 years ago

I'm not sure what code you are referring to exactly. Looking through the last release and latest in master both only notify the zookeeper service to restart if certain config templates change. Can you point me to what code you are referring to?

Sagarsaurus commented 9 years ago

Ah it was because the zoo.cfg file that I had originally had been configured manually. When it was overwritten by the chef run it still had the same attributes, just in a different order which must have triggered the restart. That's my mistake, I'll close this issue. Thank you for the help!