search

bbaugher / confluent

A Chef cookbook to install the Confluent Platform
MIT License
15 stars 7 forks source link

adds the ability to specify kafka class on startup #19

Closed popsikle closed 7 years ago

popsikle commented 7 years ago

the options in the service was needed to pass extra_args to the kafka service.

bbaugher commented 7 years ago

I'm fine adding options to pass to the start script but the start/stop scripts in the cookbook were to handle bugs in certain confluent versions. Those scripts will only be deployed for that version, here and here

popsikle commented 7 years ago

kakfa-start is a not_if so it gets generated all the time, unless version is 1.0, im guessing that is a mistake then?

bbaugher commented 7 years ago

Yes thats a mistake

popsikle commented 7 years ago

ok, well thats good to know, because i was setting the class in the startup script to be what confluent 3.1.2 uses, which was the reason for this pull!

bbaugher commented 7 years ago

I fixed the issue here, https://github.com/bbaugher/confluent/issues/20