search

bbaugher / confluent

A Chef cookbook to install the Confluent Platform
MIT License
15 stars 7 forks source link

Add tests and discoverable brokers #9

Closed TD-4242 closed 8 years ago

TD-4242 commented 8 years ago

Added tests for rubocop and foodcritic to Rakefile also addid unit tests and integration to Rakefile (Gem conflict with Berkshelf) updated kitchen config and added ubuntu 14.04

Added ability to add a list of brokers and a library to select an ID from the hash index. Added library functions for this.

Let me know if there is anything you'd like changed or done differently. There shouldn't be any compatibility changes as setting node['confluent']['kafka']['server.properties']['broker.id'] or ['zookeeper.connect'] should still work.

bbaugher commented 8 years ago

This looks good other then a few small things

TD-4242 commented 8 years ago

Funny, I didn't realize you were the cerner_kafka maintainer that I submitted to a while ago. Thanks for putting this stuff together and publishing them. Very helpful.

bbaugher commented 8 years ago

Yes I only made this as I was playing around with it at work. This looks great thanks again

bbaugher commented 8 years ago

This was released, https://supermarket.chef.io/cookbooks/confluent/versions/0.3.0