search

bbayles / python-pure-cdb

Pure Python CDB reader/writer
https://python-pure-cdb.readthedocs.io/
MIT License
40 stars 10 forks source link

Move to Python 3 only #25

Closed bbayles closed 5 years ago

bbayles commented 5 years ago

Time is short for Python 2. This PR removes six and various Python 2-isms. Most of the changes were done by the pyupgrade module, but I made a few others by hand.

In addition, Travis now exercises the C module.

dw commented 5 years ago

Hi Bo :)

Sorry, gotta reject this one. The culture of ephemerality that grips the Python community (and the modern IT industry at large) is something I simply do not subscribe to. Until such times as a feature becomes absolutely impossible to support because of compatibility concerns, I consider it a mark of craftsmanship to provide software that works regardless of scenario, free of artificial restrictions baked in to support an agenda of forced obsolescence.

I understand this is not a commonly held idea, but it's one I'll never let go of. Thanks for the effort though!

dw commented 5 years ago

I'm sorry -- this isn't fair, you have been doing all the work.

Would you like to transfer the repo? He who codes decides! And you're doing all the coding :)

bbayles commented 5 years ago

Ha, up to you. I'm happy to maintain a Python 3-only fork.

I think the last release is probably fine to use in Python 2 indefinitely; this is what I've been doing with my other projects - a final Python 2-compatible release, and then Python 3 only from then on.

dw commented 5 years ago

That's a fine idea -- cdb is a nicely non-moving target so this is possible. If you want to go that route, perhaps we should bump the major version number on next PyPI upload.

Thanks again for all your help, and apologies for overreaction -- this is a topic I'm quite heated about :)

bbayles commented 5 years ago

I should have changed the major version in this PR, you're right.

I've added the python_requires keyword to setup.py, which will ensure that Python 2 users will get the last version when using pip.

This, plus a note on the README and docs index, should make sure everybody can find what they need.

dw commented 5 years ago

This is absolutely perfect, go crazy on the merge :)