bbayles / python-pure-cdb

Pure Python CDB reader/writer
https://python-pure-cdb.readthedocs.io/
MIT License
40 stars 10 forks source link

Preparing for a new release (with Python 3 support) #7

Closed bbayles closed 6 years ago

bbayles commented 6 years ago

Greetings! I have joined this project as a maintainer (many thanks, @dw). Here is what I've been working on so far.

The big change is the addition of Python 3 support. With the help of six, this library now runs on both Python 2 and Python 3.

The other big change is to the organization of the files in the repo. I've created a traditional package structure, which makes for easier installation and testing.

In addition, I've updated setup.py to use setuptools, added the cdbmake.py script to the package installation, and updated the README with some documentation.


I'll start filing some issues and opening PRs for these items, but here's a preview of the plan:

I'll read through this PR and merge this soon to get started.

dw commented 6 years ago

This all looks great, with one exception - test_ prefix on the filenames. It breaks tab completion and drives me insane :) Other than that please feel free to merge

bbayles commented 6 years ago

Hmm, OK. I changed the test file's name.

Note that the test*.py file name pattern is needed for the python -m unittest discover function to work (see here), but python setup.py test still works. (python -m unittest discover -p "*_test.py" works also)

dw commented 6 years ago

Thanks a ton!

bbayles commented 6 years ago

Thank you! I'll ping you about making a release on PyPI after I check a few more things out with Python 3.

dw commented 6 years ago

I pushed a commit to port _djb_hash to 3.x, I left the opt-in in place since the name of the package after all is "pure" :)

bbayles commented 6 years ago

Ha, that was one of the things I was going to bring up gently a little later.