Bump Faker to 5.5.3 - Githubissues

Pharserror commented 2 years ago

Bumping faker to ^5.5.3 and replacing proper-case with lodash/startCase with Lodash at ^4.17.21.
Made some updates to logic checks
Resolved discrepancies between syntax styles by moving everything to older JS syntax to match the majority of the code
Changed anonymous functions to named functions

The reason for making this PR is I was experiencing problems giving faker.random.number() an optional JSON argument in Insomnia (it would display something exactly like what is shown in #8 & #7 .

I am now not seeing the error with the new faker.datatype.number() and values are as expected.

bbbco commented 2 years ago

Thanks for this PR.

Actually, I'd prefer to keep lodash out of this project, but I'm open to the other fixes you have made.

Please refactor without lodash.

Pharserror commented 2 years ago

@bbbco pinging you just so you know I've pushed changes, let me know if there's anything else.

bbbco commented 2 years ago

@pharserror I'm open to completing this PR, just want to ensure that it is explicitly clear what the actual changes are for this PR.

I have pushed up a Prettier version of the index.js file so hopefully the reformatting should no longer be an issue if you want to reopen this back up.

bbbco / insomnia-plugin-faker

Bump Faker to 5.5.3 #10