search

bbbco / insomnia-plugin-faker

Faker Plugin for Insomnia REST Client
71 stars 7 forks source link

Generated date should not include quotes #12

Closed wvanlit closed 1 year ago

wvanlit commented 2 years ago

When using options from Faker>Date that generate an ISO date string, it will always add double quotes around the result. This makes it hard to use in environments and requests.

image

If possible either remove the quotes, or add a modifier option to remove the quotes.

bbbco commented 1 year ago

There is a larger issue here, as there are several different Faker types that return quoted strings (Date, etc), array objects (Address > GPS Cordinates, Colors, DataType>Array, etc), and objects (DataType>JSON Object, Science, etc) which the JSON linter cannot easily parse.

I added a PR to insomnia to fix this in the regular interface: https://github.com/Kong/insomnia/pull/5136 Note, there is not yet a fix for handling this in environments. I am currently working on this problem.

JwanKhalaf commented 1 year ago

This issue is a show stopper in my case. Is there a work-around one could do until the issue is fixed?

bbbco commented 1 year ago

Hey @JwanKhalaf , we are still waiting for https://github.com/Kong/insomnia/pull/5136 to be pulled into the latest release. It has been verified and approved, just waiting for the PR to be merged in. Then, this issue can be marked as resolved in the latest insomnia release.

Feel free to comment on that PR requesting it to be merged in if you need this!

bbbco commented 1 year ago

The PR was merged in and will go into the latest version of Insomnia!

bbbco commented 1 year ago

This is now available in the latest Insomnia beta build! https://insomnia.rest/changelog#2022.7.0-beta.5