search

bbbenji / synthwave-hass

Synthwave inspired theme for Home Assistant
MIT License
154 stars 24 forks source link

update primary color to fix #24 #27

Closed CyanoFresh closed 4 years ago

CyanoFresh commented 4 years ago

This change was suggested in https://github.com/bbbenji/synthwave-hass/issues/24#issuecomment-616229998

bbbenji commented 4 years ago

Works well, thanks!

bbbenji commented 4 years ago

This fix has the side effect of breaking the active toolbar tabs on the Supervisor page.

Screen Shot 2020-05-02 at 4 07 18 PM

Instead of relying on primary-color, please define the color of the media card background separately. Once this is fixed, I will release a new version of this theme.

CyanoFresh commented 4 years ago

This fix has the side effect of breaking the active toolbar tabs on the Supervisor page.

Screen Shot 2020-05-02 at 4 07 18 PM

Instead of relying on primary-color, please define the color of the media card background separately. Once this is fixed, I will release a new version of this theme.

yep, just found this bug, too. Cannot find separate variable for media control card https://github.com/home-assistant/frontend/blob/dev/src/panels/lovelace/cards/hui-media-control-card.ts . So to fix this we need to create PR on frontend repo? Or there is another way?

bbbenji commented 4 years ago

If you want to look into a workaround, it should be possible to fix via: https://github.com/bbbenji/synthwave-hass-extras

Of course, resolving this upstream would be ideal.

Since the media card is a higher priority, in my opinion, and the active toolbar tab is still somewhat visible, I will go ahead and release this change. Thanks!