bbbradsmith / binxelview

Binxelview binary image explorer
150 stars 10 forks source link

[1.6.4.0] Doesn't open? #29

Open Deleca7755 opened 4 days ago

Deleca7755 commented 4 days ago

1.5.0.0 worked fine. I wanted the update with all the useful new features but It just simply doesn't work.

Windows 10 22h2 19045.5011

Crash dump Binxelview.exe.23436.dmp

I cloned the repo locally, when I build I get:

Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.
   at Binxelview.BinxelviewForm.redrawPixels() in C:\Users\Me Too\Documents\GitHub\binxelview\BinxelviewForm.cs:line 1519
   at Binxelview.BinxelviewForm.pixelBox_Resize(Object sender, EventArgs e) in C:\Users\Me Too\Documents\GitHub\binxelview\BinxelviewForm.cs:line 2471
   at System.Windows.Forms.Control.OnResize(EventArgs e)
   at System.Windows.Forms.PictureBox.OnResize(EventArgs e)
   at System.Windows.Forms.Control.OnSizeChanged(EventArgs e)
   at System.Windows.Forms.Control.UpdateBounds(Int32 x, Int32 y, Int32 width, Int32 height, Int32 clientWidth, Int32 clientHeight)
   at System.Windows.Forms.Control.UpdateBounds(Int32 x, Int32 y, Int32 width, Int32 height)
   at System.Windows.Forms.Control.SetBoundsCore(Int32 x, Int32 y, Int32 width, Int32 height, BoundsSpecified specified)
   at System.Windows.Forms.Control.System.Windows.Forms.Layout.IArrangedElement.SetBounds(Rectangle bounds, BoundsSpecified specified)
   at System.Windows.Forms.Layout.TableLayout.SetElementBounds(ContainerInfo containerInfo, RectangleF displayRectF)
   at System.Windows.Forms.Layout.TableLayout.LayoutCore(IArrangedElement container, LayoutEventArgs args)
   at System.Windows.Forms.Layout.LayoutEngine.Layout(Object container, LayoutEventArgs layoutEventArgs)
   at System.Windows.Forms.Control.OnLayout(LayoutEventArgs levent)
   at System.Windows.Forms.TableLayoutPanel.OnLayout(LayoutEventArgs levent)
   at System.Windows.Forms.Control.PerformLayout(LayoutEventArgs args)
   at System.Windows.Forms.Control.OnResize(EventArgs e)
   at System.Windows.Forms.Control.OnSizeChanged(EventArgs e)
   at System.Windows.Forms.Control.UpdateBounds(Int32 x, Int32 y, Int32 width, Int32 height, Int32 clientWidth, Int32 clientHeight)
   at System.Windows.Forms.Control.UpdateBounds(Int32 x, Int32 y, Int32 width, Int32 height)
   at System.Windows.Forms.Control.SetBoundsCore(Int32 x, Int32 y, Int32 width, Int32 height, BoundsSpecified specified)
   at System.Windows.Forms.Control.System.Windows.Forms.Layout.IArrangedElement.SetBounds(Rectangle bounds, BoundsSpecified specified)
   at System.Windows.Forms.Layout.TableLayout.SetElementBounds(ContainerInfo containerInfo, RectangleF displayRectF)
   at System.Windows.Forms.Layout.TableLayout.LayoutCore(IArrangedElement container, LayoutEventArgs args)
   at System.Windows.Forms.Layout.LayoutEngine.Layout(Object container, LayoutEventArgs layoutEventArgs)
   at System.Windows.Forms.Control.OnLayout(LayoutEventArgs levent)
   at System.Windows.Forms.TableLayoutPanel.OnLayout(LayoutEventArgs levent)
   at System.Windows.Forms.Control.PerformLayout(LayoutEventArgs args)
   at System.Windows.Forms.Control.OnResize(EventArgs e)
   at System.Windows.Forms.Control.OnSizeChanged(EventArgs e)
   at System.Windows.Forms.Control.UpdateBounds(Int32 x, Int32 y, Int32 width, Int32 height, Int32 clientWidth, Int32 clientHeight)
   at System.Windows.Forms.Control.UpdateBounds(Int32 x, Int32 y, Int32 width, Int32 height)
   at System.Windows.Forms.Control.SetBoundsCore(Int32 x, Int32 y, Int32 width, Int32 height, BoundsSpecified specified)
   at System.Windows.Forms.Control.System.Windows.Forms.Layout.IArrangedElement.SetBounds(Rectangle bounds, BoundsSpecified specified)
   at System.Windows.Forms.Layout.DefaultLayout.xLayoutDockedControl(IArrangedElement element, Rectangle newElementBounds, Boolean measureOnly, Size& preferredSize, Rectangle& remainingBounds)
   at System.Windows.Forms.Layout.DefaultLayout.LayoutDockedControls(IArrangedElement container, Boolean measureOnly)
   at System.Windows.Forms.Layout.DefaultLayout.xLayout(IArrangedElement container, Boolean measureOnly, Size& preferredSize)
   at System.Windows.Forms.Layout.DefaultLayout.LayoutCore(IArrangedElement container, LayoutEventArgs args)
   at System.Windows.Forms.Layout.LayoutEngine.Layout(Object container, LayoutEventArgs layoutEventArgs)
   at System.Windows.Forms.Control.OnLayout(LayoutEventArgs levent)
   at System.Windows.Forms.Form.OnLayout(LayoutEventArgs levent)
   at System.Windows.Forms.Control.PerformLayout(LayoutEventArgs args)
   at System.Windows.Forms.Control.PerformLayout()
   at Binxelview.BinxelviewForm.InitializeComponent() in C:\Users\Me Too\Documents\GitHub\binxelview\BinxelviewForm.Designer.cs:line 1450
   at Binxelview.BinxelviewForm..ctor() in C:\Users\Me Too\Documents\GitHub\binxelview\BinxelviewForm.cs:line 2711
   at Binxelview.Program.Main() in C:\Users\Me Too\Documents\GitHub\binxelview\Program.cs:line 19

:( help?

bbbradsmith commented 2 days ago

I don't know how to duplicate this. Does this happen with the current release build, or only when you build from source yourself? Can you run it in the debugger?

bbbradsmith commented 2 days ago

Have you made any changes to the source? I don't know how to get an OnResize event happening during InitializeComponent like this. In theory you could move disable_pixel_redraw = true from BinxelviewForm_Load to the BinxelviewForm constructor before InitializeComponent() to prevent redrawPixels from doing anything, but I'm not sure what conditions would cause that to happen during the constructor in the first place.

Deleca7755 commented 2 days ago

Hi, It happens with the release and when I build from source. Sorry for the confusion

No I didn't change the source. I don't know why It breaks on my machine

Deleca7755 commented 2 days ago

Building from the latest commit works

bbbradsmith commented 18 hours ago

Okay, thanks for checking that. I'll try to prepare a new release soon with that change, though I'm curious if this has happened for anyone else.