Hatari 2.5 integration - Githubissues

bbbradsmith / hatariB

Libretro core for Hatari emulation of Atari ST STE TT Falcon

GNU General Public License v2.0

20 stars 3 forks source link

Hatari 2.5 integration #42

Closed bbbradsmith closed 7 months ago

bbbradsmith commented 7 months ago

It seems that Hatari 2.5 will release soon. I think integrating this might be my last major task before considering this ready to leave the beta state.

After doing this, remember to check on the Spectre example in #37 to see if that is now supported. (Edit: it works!)

bbbradsmith commented 7 months ago

First pass merged as of 03bf35f

Things to follow up on:

[x] Are there new settings worth picking up from configuration.h
[x] 16-bit rendering support is gone, make sure it reports this to libretro, remove unneeded code from OSK
[x] Need to re-test savestate integrity again. See if IPF is stable now (also check if that new cold/warm reset code interferes). See if any new divergences were introduced.
[x] KP_LEFTPAREN / KP_RIGHTPAREN were added to the keymap, check if that's relevant to my other keyboard improvement project.

bbbradsmith commented 7 months ago

To study the hatariB changeset vs. the 2.5.0 source: https://github.com/bbbradsmith/hatariB/compare/unmerged-2.5.0..main

To study the hatari 2.4.1 vs 2.5.0 changes: https://github.com/bbbradsmith/hatariB/compare/unmerged-2.4.1..unmerged-2.5.0

For reference, the hatariB changeset in 0.3 vs. the 2.4.1 source: https://github.com/bbbradsmith/hatariB/compare/unmerged-2.4.1..0.3

(If curious, this feature can be found by putting /compare after the base URL of the repository, which gives a menu to select 2 branches. The eventual URL will have ... in the middle which compares changes since the last common branch? However, if you shorten it to .. you get a file to file comparison which is what we want here. GitHub Docs reference)

DJM75 commented 7 months ago

Great job Brad! I did some quick testing with the new Android build and everything seems to work fine (including save states, but of course old 2.4.1 save states are not compatible). I will continue to test and see if I notice anything strange... ;) When do you plan to integrate floppy disk drive sound simulation into the main build (love that, it really gives that nice "retro vibe") ?

bbbradsmith commented 7 months ago

The drive sound is something I will get to, haven't worked on it yet.

bbbradsmith commented 7 months ago

Okay, I think this passes my first round of tests now. Only really found 2 things to take care of:

SCC_UnInit was crashing when closing the second game due to a new uninitialized file handle.
sound.c had a new variable YM2149_Freq_div_2 that should have been in the savestate.