search

bbbradsmith / nsfplay

Nintendo NES sound file NSF music player
https://bbbradsmith.github.io/nsfplay/
279 stars 43 forks source link

vcm: add support for c++11/pthreads #21

Closed jprjr closed 4 years ago

jprjr commented 4 years ago

This just uses some #ifdefs to pick a mutex implementation.

bbbradsmith commented 4 years ago

If this is to support other compilers, please have the #define keep the existing Windows implementation AS IS and not switch to a new mutex implementation. The new way should only apply to the new platforms you are targeting.

Just to explain why, again this is about avoiding wasted work for when this is all thrown away for version 3. If you don't restrict the changes to new compilers only, I can't accept the pull without doing testing it (and thread testing is intensive work), so this is really not something I want to tackle for code that will not be maintained past version 2.5.

jprjr commented 4 years ago

That totally makes sense - rebased and pushed up a version that defaults to the existing Windows version by default.