Fix remaining gcc/clang "-Wall" warnings

bbbradsmith / nsfplay

Nintendo NES sound file NSF music player

https://bbbradsmith.github.io/nsfplay/

279 stars 43 forks source link

Fix remaining gcc/clang "-Wall" warnings #27

Closed jprjr closed 4 years ago

jprjr commented 4 years ago

This fixes all warnings when compiling with "-Wall" on the latest gcc and clang

jprjr commented 4 years ago

Note: I haven't had the opportunity to fire up my Windows VM and test - and in the middle of typing this, it looks like the appveyor build failed. Looks like an error around me changing some "char " functions to return "const char ". I'll get that fixed.

bbbradsmith commented 4 years ago

was worried the play_addr removal from 14b83fa5 was hiding a bug, but looks like the same thing was redundantly implemented within cpu.Start, so it was fine