Closed Gumball2415 closed 1 year ago
There is a system in place for allowing selection of past patch sets, so we should not simply replace a patch set like this. Instead create a new set among the existing collection. That way the user can still access the older patch set.
Your pull request comment just has 3 checkboxes, one unfilled. Is that something that is intended for a different pull request later, or was this a work in progress?
it's currently a work in progress. i tried to update emu2149 to v1.30, but there was some current bugs regarding envelope period, and i saw that the author is planning to resolve that soon. digital-sound-antiques/emu2149#3
updates to emu2149 will now be in a seperate PR