search

bbbscarter / GodotRuntimeDebugTools

A proof-of-concept Godot addon to improve the runtime debugging experience
MIT License
152 stars 3 forks source link

Switching to RDT and back to normal FPS camera #3

Closed GonnaFlyMethod closed 1 month ago

GonnaFlyMethod commented 2 months ago

Hi, the addon looks interesting, I wonder what is the way to switch between default Character camera and Freelook camera from the addon? So, for example, I run the scene, and I have Godot's default FPS camera that is designed for gameplay, and then in some moment I want to switch to Freelook(debug) camera in order to observe the game world. For now, when I start the game from the editor, I immediately getting a Freelook camera without opportunity to switch to the player's view.

It would be nice to switch back and fourth between these cameras

bbbscarter commented 2 months ago

Ah, I think this is a regression in the situation where the scene has no defined 'current' camera; because the debug camera is the first in the scene, it's erroneously picked as the 'current' camera.

I've just pushed a fix to github - let me know if it fixes it for you and I'll push it up to the asset library.

GonnaFlyMethod commented 2 months ago

Hey, the problem is on my side: I haven't set up check box "Current" on my main Character camera 3D. After that, switching between Character main camera and Debug 3D camera back and fourth went smooth(I've checked on both versions: v1.1.0 and v1.1.1). May be, let's add a note to README for future godoters, what do u think?

Proposal for enhancement: The only thing I've discovered is that when switching back from Debug3D camera to Main Character camera, the mouse input mode is not preserved: I'm testing the game in windowed mode, when I start it the mouse is enteirely hidden: 

Input.MouseMode = Input.MouseModeEnum.Captured;

then, I do ALT + TAB to quickly navigate to godot and hit RDT (3D Debug camera). After that, I'm switching back to Character camera (FPS camera) by unchecking 3D Debug camera in RDT, and the mouse is visible, and because of it, when I want to rotate a character, the character rotates as long as the mouse cursor is presented in the game window, if the cursor exits from the window frame, then the character stop rotating. My proposal is to preserve the mouse input mode when switching back to the game camera. By the way, in order not to ALT+ TAB each time, may be shortcuts can be introduced in game process?

bbbscarter commented 2 months ago

Hey, the problem is on my side: I haven't set up check box "Current" on my main Character camera 3D. After that, switching between Character main camera and Debug 3D camera back and fourth went smooth(I've checked on both versions: v1.1.0 and v1.1.1). May be, let's add a note to README for future godoters, what do u think?

Yup, that's another way of fixing it, certainly, but my preference is that users don't have to change their projects if possible. The fix I've pushed will hopefully fix it for everyone, without any local changes needed.

Proposal for enhancement:

Thanks, I can look into that! Would you be able to propose this in a new issue, so I can keep this one focused on the original issue you reported?

By the way, in order not to ALT+ TAB each time, may be shortcuts can be introduced in game process?

There is currently a hidden option to do this - F12. My intention is to make that configurable in the future, which is why it hasn't been documented yet. :)

GonnaFlyMethod commented 2 months ago

Hey, by the way with 1.1.1 before switching Character camera to "Current", when I was hitting "Play" the default camera was the one that was placed in the center of the map[it looks like this camera was added by debug tools].

bbbscarter commented 2 months ago

Yup, that would be my expectation - it would have erroneously picked up the debug camera as the 'current' camera, and the debug camera is initally at (0,0,0).

This should be fixed in 1.1.2 (pending review in the asset library), or current github head.

GonnaFlyMethod commented 2 months ago

I've created a separated issue with more details about preserving mouse input mode, by the way, I would like to contribute to the project, do you consider new contributors now 🙂?

bbbscarter commented 2 months ago

I'm certainly happy to consider pull-requests!

GonnaFlyMethod commented 2 months ago

hey, cool. I think, I'll to check out the codebase on this weekend and let you know how it goes. I would like to work on my proposal

bbbscarter commented 1 month ago

Fixed in #5

Thanks!

GonnaFlyMethod commented 1 month ago

Hey, btw, will you create a new version with the fix included?

bbbscarter commented 1 month ago

Ah yes, I was a bit slow returning to this.

It should be live as of earlier today (v 1.1.3).

On Thu, 26 Sep 2024 at 19:10, Aliaksandr Husakou @.***> wrote:

Hey, btw, will you create a new version with the fix included?

— Reply to this email directly, view it on GitHub https://github.com/bbbscarter/GodotRuntimeDebugTools/issues/3#issuecomment-2377622756, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHDB67EJM3EY7H3DNKT3GTZYRE25AVCNFSM6AAAAABNBSQ2SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGYZDENZVGY . You are receiving this because you modified the open/close state.Message ID: @.***>

GonnaFlyMethod commented 1 month ago

cool, may be let's connect in discord? What do you think? It will allow for fast communication

bbbscarter commented 1 month ago

Sure! I'm sometimes on Discord - also email/Google chat/Mastodon work for me!

On Thu, 26 Sept 2024 at 19:17, Aliaksandr Husakou @.***> wrote:

cool, may be let's connect in discord? What do you think? It will allow for fast communication

— Reply to this email directly, view it on GitHub https://github.com/bbbscarter/GodotRuntimeDebugTools/issues/3#issuecomment-2377632722, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHDB66AJ2VMNFDUMWRQAFTZYRFSBAVCNFSM6AAAAABNBSQ2SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGYZTENZSGI . You are receiving this because you modified the open/close state.Message ID: @.***>

GonnaFlyMethod commented 1 month ago

Let's connect on discord? My nickname is gonnaflymethod. The same avatar as in github

bbbscarter commented 1 month ago

Sure, will do. I'm @bbbscarter everywhere as well.

On Fri, 27 Sept 2024 at 08:13, Aliaksandr Husakou @.***> wrote:

Let's connect on discord? My nickname is gonnaflymethod. The same avatar as in github

— Reply to this email directly, view it on GitHub https://github.com/bbbscarter/GodotRuntimeDebugTools/issues/3#issuecomment-2378561259, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHDB63NKS3D6NQPJXE2GSTZYUAQDAVCNFSM6AAAAABNBSQ2SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGU3DCMRVHE . You are receiving this because you modified the open/close state.Message ID: @.***>