search

bbbtech / storybook-formik

A storybook decorator that allows you to use components in your stories that rely on Formik context.
53 stars 17 forks source link

feat: support cjs and esm #42

Closed italoteix closed 2 years ago

italoteix commented 2 years ago

Aiming for multiple targets will allow us to use this addon for tests with @storybook/testing-react as it runs with jest.

bhishp commented 2 years ago

Hey, thanks for this, I'll get a chance to check it out today. I see you're still making commits, let me know when you're happy with it/finalised

italoteix commented 2 years ago

Hey, thanks for this, I'll get a chance to check it out today. I see you're still making commits, let me know when you're happy with it/finalised

Thanks for your time. I'm still doing some tests on my app to check if it's 100% working. But at least on the provided examples, it is working.

italoteix commented 2 years ago

@bhishp It seems to be working, but I'm thinking on add some tests to show the use case. Do you mind if I do the jest and testing-library setup?

bhishp commented 2 years ago

sure thing, sounds like a plan, thanks @italoteix

italoteix commented 2 years ago

@bhishp I think that now I'm done with this PR. Can you check it now?

bhishp commented 2 years ago

I have just released this feature (along with several dependency upgrades) in v2.4.0. Let me know if you encounter any issues. Thanks again for your contribution

https://www.npmjs.com/package/storybook-formik/v/2.4.0