search

bbc / Imager.js

Responsive images while we wait for srcset to finish cooking
Apache License 2.0
3.84k stars 224 forks source link

-- #20

Closed thom4parisot closed 10 years ago

thom4parisot commented 11 years ago

Content moved in #32

Integralist commented 11 years ago

@oncletom Sounds good. I'll start going through each proposal and will feedback any thoughts I have. If I think any one proprosal is good enough to be started (without me needing to comment or make suggestions for change) then I'll say so in the comment and then close the issue so we know that it's OK to go ahead.

Otherwise the proposals will stay as open issues so we can continue discussions. Hope that all sounds OK?

Integralist commented 11 years ago

@oncletom Actually, correcting myself... even if I do like the issue raised I will comment on it to say so (as I suggested above) but I'll leave the issue open until a separate PR has actually been made (and merged) that way I know it's a still outstanding issue.

thom4parisot commented 11 years ago

That's perfect :-)

Actually with the hub program, it is possible to transform an issue in a PR so it will be quite easy to have both discussions and code in the same issue.

Integralist commented 11 years ago

@oncletom awesome! that's good :-)

thom4parisot commented 10 years ago

Actually I don't want it to be merged in master, missed it ;-(