Closed thom4parisot closed 10 years ago
This one is for you @maslen :sunglasses:
@oncletom this is a comment just for my own purposes (when I check here again later) that there is one issue outstanding which relates to how the 1030 clientWidth should be handled (I personally think a 1024 image should be loaded as it's nearest, and not revert to default 320)
@oncletom this looks good to me, but it can't be merged at the moment so once that build is passing then just let me know and I'll press the merge button :-)
Rebased :-)
Brilliant thanks @Integralist :-)
@oncletom no problem, sorry it's taking so long between comments to get back to you. Just busy busy busy :-/ but getting there! :-)
I'll now put some efforts to propose an updated README documentation to cover the new features so as it could be released in master
.
Do you think about something else before we can reach this level of satisfaction?
PS: no problem for the busy-ness :-) We all are I think.
@oncletom no I think this is probably a good point to get some good documentation in place so we can hook it all back into master :-)
Alternative implementation of #21. It adds 2 more commits that enables
availableWidths
to be either an array of values or a function.