Amd commonjs - Githubissues

bbc / Imager.js

Responsive images while we wait for srcset to finish cooking

Apache License 2.0

3.84k stars 224 forks source link

Amd commonjs #40

Closed joewillnyc closed 10 years ago

joewillnyc commented 10 years ago

Add support for commonjs and amd modules

Integralist commented 10 years ago

I'll take a look in the morning to see how this compares to UMD's format as if we're going to support a group of different system then I'd rather use something as recognised such as UMD

thlorenz commented 10 years ago

@Integralist not sure what UMD adds besides what @joewillnyc proposed.

As far as I understand UMD supports:

AMD i.e. requirejs
commonJS (node, browserify)
global window object

All of these are supported here.

However we'll redo the PR anyways to remove the unnec. add main/remove main commits.

joewillnyc commented 10 years ago

Created a PR without the add/remove commits here: https://github.com/BBC-News/Imager.js/pull/41