bbc / Imager.js

Responsive images while we wait for srcset to finish cooking
Apache License 2.0
3.84k stars 224 forks source link

[READY] Cleaning codebase #44

Closed thom4parisot closed 10 years ago

thom4parisot commented 10 years ago

tl;dr

Removing some code which is not useful anymore thanks to the latest merges in refactoring-base.

What has been done

This last part needs to get attention. While cleaning it I wondered why a replaceChild occurred systematically in replaceImagesBasedOnScreenDimensions. I considered this part should just have to update the placeholder src attribute.

Useless things can be removed by discarding some commits, I tried to make them releventelly atomic :-)