search

bbc / Imager.js

Responsive images while we wait for srcset to finish cooking
Apache License 2.0
3.84k stars 224 forks source link

https://github.com/BBC-News/Imager.js/issues/45 #46

Closed Tarqwyn closed 10 years ago

Tarqwyn commented 10 years ago

@Integralist

Really simple PR.

makes working with regex's slightly easier as they can be environment agnostic even if the image path needs to be fully qualified (i.e. a cdn), defaults to relative pathing..

thom4parisot commented 10 years ago

@Tarqwyn, do you think the future use of {width} provided by #21 will address your issue?

Tarqwyn commented 10 years ago

@oncletom. Whoops didn't see that branch... absolutely a much cleaner way of handling the whole problem... How far would you anticipate taking this approach? Is there any milage in allowing the user to pass in there own template/options allowing complete flexibilty and possible futureproofing, just an idea but I'm not sure its a good one :) as it may add complexity to the code which is seldom used...

Anyhow the initial problem is fixed in your branch so pretty sure this can be closed

thom4parisot commented 10 years ago

@Tarqwyn good to know :-) well not anticipating too much is the plan for the moment, to avoid unnecessary abstractions/code. We'll see what is needed after that reaches master, as a plugin or as a core feature. What kind of other placeholders were thinking about? You can have a look at the future version of Imager in the upcoming feature-documentation branch :-)