search

bbc / VideoContext

An experimental HTML5 & WebGL video composition and rendering API.
http://bbc.github.io/VideoContext/
Apache License 2.0
1.33k stars 157 forks source link

Avoid hardcoded values for nodes #112

Closed germain-gg closed 6 years ago

germain-gg commented 6 years ago

Hey,

As I was going through some of the codebase, I've updated bits of it to avoid hardcoded values

PTaylour commented 6 years ago

The unit tests that import directly from a src/SourceNode/<name> are failing due to Super expression must either be null or a function, not object

Potentially something like a circular reference

PTaylour commented 6 years ago

Those classes extend the default export, which should also be a class.

Something is causing the jest transpiler to wrap the exports in an object?

PTaylour commented 6 years ago

Re-ordering some of the inputs has prevented this. Merging now