search

bbc / VideoContext

An experimental HTML5 & WebGL video composition and rendering API.
http://bbc.github.io/VideoContext/
Apache License 2.0
1.32k stars 157 forks source link

Typescript conversion? #243

Open jjeff opened 1 year ago

jjeff commented 1 year ago

I see some discussion here about either providing an index.d.ts (Typescript typings) file along with VideoContext or, just converting the entire library to Typescript – which IMO would be more maintainable. However, I'm not a maintainer – and that issue has been closed.

I might have some energy to do a Typescript conversion. However, before I do this, I'd like to hear from a maintainer (someone at the @bbc?) about whether they'd be open to this change. I would try to keep things intact as much as possible, but all of the src/*/.js files will become .ts files, so from a git perspective, it's a pretty major overhaul.

Luckily, with webpack, there's already a compilation workflow. So things wouldn't change much in terms of publishing workflow… (should VideoContext ever be published to npm again).

So before I dive in, what are the chances that this PR would land? @yakca?

yakca commented 1 year ago

@jjeff we're definitely still open to PRs and contributions to the project. TypeScript has gained significant momentum over the years since that previous issue was raised, so I'd be happy to merge something like this to main branch pending the usual linting and tests requirements.