search

bbc / alephant-broker

Brokers requests for alephant components
MIT License
4 stars 3 forks source link

README Example #33

Closed Integralist closed 9 years ago

Integralist commented 9 years ago

I'm not sure if the README example (https://github.com/BBC-News/alephant-broker#s3-load-strategy) is correct?

config = {
  :bucket_id         => 'test_bucket',
  :path              => 'foo',
  :lookup_table_name => 'test_lookup'
}

We can see in https://github.com/BBC-News/alephant-broker/blob/master/lib/alephant/broker/load_strategy/s3.rb#L59-L60 that Broker.config tries to get bucket and path using the keys s3_bucket_id and s3_object_path which don't correlate to the example config used in the README.