search

bbc / alephant-broker

Brokers requests for alephant components
MIT License
4 stars 3 forks source link

Exception thrown when using NullClient triggering additional unnecessary dynamo calls #34

Closed stevenjack closed 9 years ago

stevenjack commented 9 years ago

dodge_ball

Problem

When using the NullClient for brokers that don't use the cache (generally in development), the application was making two calls to the lookup table as the cache.set method was throwing an exception due to the wrong number of params passed to the set method. This in turn was then caught in the rescue block of the load method which then tried to get the lookup location again.

Solution

Add missing param to set method of NullClient.

In this PR we now pass the id to the sequencers get_last_seen method, meaning we only have to construct the sequence class once.

stevenjack commented 9 years ago

@revett bop, fancy dishing out some sweet :fish_cake: ?

revett commented 9 years ago

:cake: