search

bbc / alephant-broker

Brokers requests for alephant components
MIT License
4 stars 3 forks source link

Extract Base functionality from S3 Loading Strategy #38

Closed darnould closed 9 years ago

darnould commented 9 years ago

gif

Problem

We need to support accessing archived content from S3 that no longer needs sequencing by DynamoDB.

Solution

Prepatory refactor: extract S3::Base, create S3::Sequenced < S3::Base with sequencing functionality, for a subsequent S3::Archived < S3::Base to be added.

Release

Major. Consuming application now needs to point to either Sequenced or Archived - previously used an S3 class (now a module).

stevenjack commented 9 years ago

really nice :+1:

stevenjack commented 9 years ago

Can we get the travis build passing otherwise the label on the PR is going to state build failing

revett commented 9 years ago

:cake: after Rubocop offences have been fixed.

darnould commented 9 years ago

Looks like we've got a few Rubocop configurations to iron out first :)