search

bbc / alephant-broker

Brokers requests for alephant components
MIT License
4 stars 3 forks source link

Re-enable broker response code metrics. Add metric for batch requests #56

Closed zygotic99 closed 8 years ago

zygotic99 commented 8 years ago

Broker metrics for HTTP response codes haven't worked for a while, and were effectively removed in alephant-broker 3.6.1

Newsbeat-broker records a flat line for response code metrics, regardless of code AMP and Elections send no response metrics.

There are other issues with metrics (S3InvalidCacheKey means couldn't find the key in S3, for example, it is not related to the cache.rb Elasticache stuff and the key was not invalid). But I'd like to get this fix in to AMP before launch, so restricting changes looking for quick :cake:

samfrench commented 8 years ago

:+1: :cake:

How was it working previously? 3.6.1 removed a log_status method, but that wasn't being used by anything?

zygotic99 commented 8 years ago

@samfrench I kind of assumed that metrics haven't been borked forever, and I thought i'd seen them work in AMP before I upgraded versions of various gems.

404s seem to have generated dots on the CW graphs in the past, for example.

To answer how it was working previously, though - I dont know!

zygotic99 commented 8 years ago

No :cake: because tests fail :(

zygotic99 commented 8 years ago

Can I have cake now? :)