search

bbc / alephant-broker

Brokers requests for alephant components
MIT License
4 stars 3 forks source link

Small additions #71

Closed dazoakley closed 8 years ago

dazoakley commented 8 years ago

The first commit in this PR adds simplecov to the test suite giving us some code coverage metrics. I don't tend to get obsessive about coverage, but when picking up a new project it's a good way of telling you where to tread carefully...

Here's a couple of screenshots of it in action both on the shell and the generated HTML report (stored in the generated /coverage directory):

simplecov-shell

simplecov-html

The second commit is the result of running rubocop -a . in the root of the repo using the style guidelines defined in https://github.com/BBC-News/rubocop-config.

Integralist commented 8 years ago

Couple of minor comments, but otherwise seems fine. Be good to see a more descriptive PR description :-)

dazoakley commented 8 years ago

All updated with your comments, the PR description too.

Integralist commented 8 years ago

@dazoakley 👍