search

bbc / audiowaveform

C++ program to generate waveform data and render waveform images from audio files
https://waveform.prototyping.bbc.co.uk
GNU General Public License v3.0
1.94k stars 242 forks source link

OSX package #22

Open thom4parisot opened 9 years ago

thom4parisot commented 9 years ago

Maybe by using FPM, cf. http://macops.ca/rolling-os-x-packages-with-fpm-and-homebrew/

rivimey commented 5 years ago

I was able to build on OSX as soon as the libs (from brew) and cmake were set up. I didn't bother with the test suite, and so passed the disable tests -D flag to cmake.

I will note there were quite a few signed/unsigned conversion warnings, mostly for 'counting' values like the size of an array, the number of samples, etc. These could be fixed by changing particular 'int' vars to 'unsigned', but the ripple effect is significant... To be clear, the program works fine without change.

chrisn commented 5 years ago

Thanks, @rivimey ... looks like we're missing -Wsign-conversion in the compiler flags. We should fix those warnings, really.

Regarding the OSX package, is this still needed, as we have a homebrew formula? I'm not a Mac user, so I'd need advice on the best way to resolve this issue.