bbc / bbc-a11y

BBC Accessibility Guidelines Checker
http://www.bbc.co.uk/guidelines/futuremedia/accessibility/mobile
Apache License 2.0
140 stars 28 forks source link

Depreciated modules #326

Closed mgifford closed 1 year ago

mgifford commented 3 years ago

In running the installer I came across the following errors:

npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated debug@4.1.1: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated fs-promise@2.0.3: Use mz or fs-extra^3.0 with Promise Support

These are just warnings, but probably should be addressed.

JamieKnightBBC commented 3 years ago

Hi,

Please can you share some additional details on how you installed the tools. I can't replicate these warnings, via the npm install --global method or with a local install.

Thanks,

Jamie

mgifford commented 3 years ago

I just installed this again and couldn't replicate it either. Thanks for getting back to me @JamieKnightBBC!

mgifford commented 3 years ago

Sorry, multitasking.. Some days it backfires.

$ cd ..
$ git clone https://github.com/bbc/bbc-a11y.git
Cloning into 'bbc-a11y'...
remote: Enumerating objects: 95, done.
remote: Counting objects: 100% (95/95), done.
remote: Compressing objects: 100% (72/72), done.
remote: Total 4865 (delta 52), reused 45 (delta 21), pack-reused 4770
Receiving objects: 100% (4865/4865), 1.59 MiB | 5.14 MiB/s, done.
Resolving deltas: 100% (2872/2872), done.

$ cd bbc-a11y/

$ npm install bbc-a11y --global

npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated fs-promise@2.0.3: Use mz or fs-extra^3.0 with Promise Support
/usr/local/bin/bbc-a11y -> /usr/local/lib/node_modules/bbc-a11y/bin/bbc-a11y.js

> electron@2.0.18 postinstall /usr/local/lib/node_modules/bbc-a11y/node_modules/electron
> node install.js

Downloading SHASUMS256.txt
[============================================>] 100.0% of 5.39 kB (5.39 kB/s)
+ bbc-a11y@2.4.2
added 183 packages from 145 contributors in 26.489s

   ╭─────────────────────────────────────────────────────────────────╮
   │                                                                 │
   │      New patch version of npm available! 6.14.8 → 6.14.11       │
   │   Changelog: https://github.com/npm/cli/releases/tag/v6.14.11   │
   │                Run npm install -g npm to update!                │
   │                                                                 │
   ╰─────────────────────────────────────────────────────────────────╯
ermi-ltd commented 3 years ago

Hi,

Fab! That’s super helpful.

I still cant replicate all of the warnings which is strange. Please could ya let me know which version of node your using?

Cheers,

Jamie + Lion

mgifford commented 3 years ago

% node -v v14.15.4 % npm -v 6.14.10

On a Mac (11.2)

It may be my version of node

JamieKnightBBC commented 3 years ago

Fab, I have been able to replicate! I'll have a prod shortly. Thanks again for letting us know.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 5 days with no activity.